-1 due to .mvn/wrapper/maven-wrapper.jar maven-wrapper.jar is a binary file, and we cannot have binary files in source distributions. (Note that ./mvnw can bootstrap just fine without it. Also note that it is not checked into git — I guess it is created during the release build process.)
Everything else was fine. Checked hashes, KEYS, LICENSE, NOTICE, README; checked that contents of tar match git; compiled and ran tests using JDK 11 on Ubuntu linux. Julian > On Mar 14, 2019, at 10:30 AM, Vladimir Sitnikov <[email protected]> > wrote: > > +1 (binding) > > Checksum matches, the code compiles. > Release notes look ok. > > Thanks, Kevin > > Vladimir
