I’m not voting, I just want to say something to this HydromaticFileSetCheck
>* HydromaticFileSetCheck produces hard to understand messages. I guess many of you have faced "Open parentheses exceed closes by 2 or more [HydromaticFileSet]" issue, and I guess you it took you a lot to understand what the error really means. * HydromaticFileSetCheck duplicates logic which is already implemented elsewhere (e.g. fail on tab characters, end with newline) * HydromaticFileSetCheck produces errors when automatic correction is possible. For instance, "@Override should not be on its own line" * "// End ..." file footer is redundant, and sometimes it is misleading (e.g. // End Parser.jj is retained even in the generated parser which makes no sense). 1. “Open parentheses exceed closes by 2 or more” seems not very hard to understand, actually straightforward for me. 2. "// End ..." file footer is redundant, and sometimes it is misleading: I don’t think it is redundant, it normalize the file end pretty well(avoid all kinds of file end), personally I like this style. 3. “ // End Parser.jj is retained even in the generated parser which makes no sense” I think this is not that much important. Best, Danny Chan 在 2019年12月4日 +0800 PM6:31，[email protected]，写道： > > * HydromaticFileSetCheck produces hard to understand messages. I guess many > of you have faced "Open parentheses exceed closes by 2 or more > [HydromaticFileSet]" issue, and I guess you it took you a lot to understand > what the error really means. > * HydromaticFileSetCheck duplicates logic which is already implemented > elsewhere (e.g. fail on tab characters, end with newline) > * HydromaticFileSetCheck produces errors when automatic correction is > possible. For instance, "@Override should not be on its own line" > * "// End ..." file footer is redundant, and sometimes it is misleading > (e.g. // End Parser.jj is retained even in the generated parser which makes > no sense).
