Enrico, thanks for your feedback. I also had a similar experience with my downstream project.
If I am not mistaken, esri library so far was not necessary because it was used just on Calcite test; however, as you say, now it is required since it is used for Calcite build. The root cause of this change seems to be CALCITE-1861 [1], implemented via [2]. I think there is not much we can do about it. Regarding the new SEARCH operator, I also had to adjust my code. For me, the easiest way to "keep things working as before" was basically adding a "RexUtil#expandSearch" call at the appropriate place in order to convert the SEARCH into its equivalent non-search expression. Best, Ruben [1] https://issues.apache.org/jira/browse/CALCITE-1861 [2] https://github.com/apache/calcite/commit/eab043f4ef43112c16a9f6708e6c53a15b1cfbe0 On Mon, Oct 5, 2020 at 3:17 PM Enrico Olivelli <[email protected]> wrote: > Ruben, > I am testing the RC, I found that now it is mandatory to have > "com.esri.geometry:esri-geometry-api" on the classpath in order to use the > Programs class. > > In HerdDB we were excluding that third party dependency, and we would like > not to depend on it in order to bring in as few third party deps as > possible (and have smaller binaries). > So I would cast a -1 > (also it would be super good to not have to depend > on com.jayway.jsonpath:json-path, but that needed dependency was there > before 1.26 and there is no need to change it now) > > I can try to work on this issue as soon as possible if you think it is > worth it. > > Apart from that we are trying to make it work to switch to the "SEARCH" > operator, that is a big behavior change. > I guess there is no way to disable it. But I am fine with that, I knew that > it is only a matter of implementing that operator as well. > > Enrico > > Il giorno lun 5 ott 2020 alle ore 14:42 Vladimir Sitnikov < > [email protected]> ha scritto: > > > Thanks for preparing an RC. > > > > +1 > > > > Build works for me modulo > > https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction > > fails in Russian locale. > > > > Checksums match, signature validation passes. > > The release notes look good. > > > > changelog> Compatibility: Guava versions 19.0 to 29.0-jre > > > > I see build scripts are using Guava 29.0-jre only. I guess Guava 19 > support > > comes like "hope it works". > > > > Vladimir > > >
