+1 (non binding) Run tests (AdoptOpen JDK14) Verified signature and sha512 Run tests of HerdDB. I noticed the new hard dependency on Geometry (but there is an hacky workaround), and the new SEARCH operator, that looks cool, even if it will require a few cycles to adapt code to the new Operator (RexUtil to the rescue!)
Ruben, I have found this trick in order to drop Geometry and JSON Path dependencies. https://github.com/diennea/herddb/pull/707 Thank for driving the release Enrico Il giorno mar 6 ott 2020 alle ore 05:31 Andrei Sereda <[email protected]> ha scritto: > +1 (non-binding). > > - build locally: ok > - check git hash: ok > - check sha512 for artifacts: ok > - check GPG signature: ok > > openjdk version "1.8.0_212" > > Note that I'm getting 404 for your public GPG key located here: > https://people.apache.org/keys/committer/rubenql.asc > So I've used Calcite KEYS instead. > > Thanks for RC, Ruben! > > > On Mon, Oct 5, 2020 at 10:46 PM Danny Chan <[email protected]> wrote: > > > +1 (binding). > > > > - run tests locally: ok > > - verify the commit hash in git tag: ok > > - check sha512: ok > > > > Environment: > > - java version 1.8.0_151 > > - MacOS Mojave 10.14.6 > > > > I also find the new introduced ersi library when i do upgrade for Flink. > I > > solves the problem by adding a dependency for it. It is awesome if we can > > avoid it. But it is not a blocker I guess. > > > > Enrico Olivelli <[email protected]>于2020年10月5日 周一下午10:58写道： > > > > > Il giorno lun 5 ott 2020 alle ore 16:43 Ruben Q L <[email protected]> > ha > > > > > > scritto: > > > > > > > > > > > > > Enrico, > > > > > > > > > > > > > > thanks for your feedback. I also had a similar experience with my > > > > > > > downstream project. > > > > > > > > > > > > > > If I am not mistaken, esri library so far was not necessary because > it > > > was > > > > > > > used just on Calcite test; however, as you say, now it is required > > since > > > it > > > > > > > is used for Calcite build. > > > > > > > The root cause of this change seems to be CALCITE-1861 [1], > implemented > > > via > > > > > > > [2]. I think there is not much we can do about it. > > > > > > > > > > > > > > > > > > > So probably this is the line that introduces that hard dependency > > > > > > > > > > > > https://github.com/apache/calcite/commit/eab043f4ef43112c16a9f6708e6c53a15b1cfbe0#diff-39080ab40de0df7a4df59ca135c79d2fR377 > > > > > > > > > > > > I will try to find some fix, at least to not fail the loading of > Programs > > > > > > class > > > > > > I am going to file a JIRA for this case > > > > > > > > > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Regarding the new SEARCH operator, I also had to adjust my code. > > > > > > > For me, the easiest way to "keep things working as before" was > > basically > > > > > > > adding a "RexUtil#expandSearch" call at the appropriate place in > order > > to > > > > > > > convert the SEARCH into its equivalent non-search expression. > > > > > > > > > > > > > > Best, > > > > > > > Ruben > > > > > > > > > > > > > > [1] https://issues.apache.org/jira/browse/CALCITE-1861 > > > > > > > [2] > > > > > > > > > > > > > > > > > > > > https://github.com/apache/calcite/commit/eab043f4ef43112c16a9f6708e6c53a15b1cfbe0 > > > > > > > > > > > > > > > > > > > > > On Mon, Oct 5, 2020 at 3:17 PM Enrico Olivelli <[email protected]> > > > > > > > wrote: > > > > > > > > > > > > > > > Ruben, > > > > > > > > I am testing the RC, I found that now it is mandatory to have > > > > > > > > "com.esri.geometry:esri-geometry-api" on the classpath in order to > > use > > > > > > > the > > > > > > > > Programs class. > > > > > > > > > > > > > > > > In HerdDB we were excluding that third party dependency, and we > would > > > > > > > like > > > > > > > > not to depend on it in order to bring in as few third party deps as > > > > > > > > possible (and have smaller binaries). > > > > > > > > So I would cast a -1 > > > > > > > > (also it would be super good to not have to depend > > > > > > > > on com.jayway.jsonpath:json-path, but that needed dependency was > > there > > > > > > > > before 1.26 and there is no need to change it now) > > > > > > > > > > > > > > > > I can try to work on this issue as soon as possible if you think it > > is > > > > > > > > worth it. > > > > > > > > > > > > > > > > Apart from that we are trying to make it work to switch to the > > "SEARCH" > > > > > > > > operator, that is a big behavior change. > > > > > > > > I guess there is no way to disable it. But I am fine with that, I > > knew > > > > > > > that > > > > > > > > it is only a matter of implementing that operator as well. > > > > > > > > > > > > > > > > Enrico > > > > > > > > > > > > > > > > Il giorno lun 5 ott 2020 alle ore 14:42 Vladimir Sitnikov < > > > > > > > > [email protected]> ha scritto: > > > > > > > > > > > > > > > > > Thanks for preparing an RC. > > > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > > > Build works for me modulo > > > > > > > > > https://issues.apache.org/jira/browse/CALCITE-2816 > PsTableFunction > > > > > > > > > fails in Russian locale. > > > > > > > > > > > > > > > > > > Checksums match, signature validation passes. > > > > > > > > > The release notes look good. > > > > > > > > > > > > > > > > > > changelog> Compatibility: Guava versions 19.0 to 29.0-jre > > > > > > > > > > > > > > > > > > I see build scripts are using Guava 29.0-jre only. I guess Guava > 19 > > > > > > > > support > > > > > > > > > comes like "hope it works". > > > > > > > > > > > > > > > > > > Vladimir > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
