Ok, https://github.com/apache/incubator-calcite/pull/144 should be good to go now. It includes Bruno's 912 (with the minor nits you found, Julian, fixed, then my 645 and 908. I made some minor modifications over my original changes in 645 because we both touched the same code. I think it's a nice improvement over what I had initially.

After we get to the protobuf-3-beta, I'll try to coalesce the PRs that require recompilation all into one PR to make your life easier, Julian.

I appreciate your legwork.

Julian Hyde wrote:
Ah, 645 and 903 also need protobuf changes. They're both yours Josh.
Let me know what order you would like me to commit these PRs.

On Wed, Oct 21, 2015 at 1:04 PM, Julian Hyde<[email protected]>  wrote:
Because we check in code generated by protobuf, merging commits that affects 
protobuf is not possible. (Grrr. I knew there was a reason not to check in 
generated code.)

Several of these patches touch protobuf: including 908, 912, 871 (which relies 
on 912). Any more?

If we want to get all of these patches into 1.5, you will need to be responsive.

Josh&  Bruno, please get together and figure out which order your patches 
should be committed, and email this list when you have the first pull request. Base 
it on the latest master, which will shortly contain CALCITE-927.

Julian


On Oct 20, 2015, at 12:08 PM, Josh Elser<[email protected]>  wrote:

I've been trying to track some of the outstanding pull requests for 
Avatica-related fixes. I'd love to see this list included in 1.5.

https://issues.apache.org/jira/browse/CALCITE-927
https://issues.apache.org/jira/browse/CALCITE-921
https://issues.apache.org/jira/browse/CALCITE-919
https://issues.apache.org/jira/browse/CALCITE-913
https://issues.apache.org/jira/browse/CALCITE-912
https://issues.apache.org/jira/browse/CALCITE-908
https://issues.apache.org/jira/browse/CALCITE-903
https://issues.apache.org/jira/browse/CALCITE-871
https://issues.apache.org/jira/browse/CALCITE-645

I think most of them are in a good position, a few might require some more 
polishing.

- Josh

Julian Hyde wrote:
When would be a good time for our next release?

Here are some dates:
* We aim to release "every month or so".
* 1.4 was released on 9/2 [1].
* It takes about 2 weeks to release, so if we started today, we could
release on about 10/13.
* The Apache board meeting is on 10/14 [2] and if the vote to
establish Calcite passes we would make our first release as a
top-level project as early as 10/21.

Does anyone have any other constraints, e.g. features they would like
to complete?

Jesus, could you take on the release manager role?

Julian

[1] http://calcite.incubator.apache.org/docs/history.html#v1-4-0
[2] http://www.apache.org/foundation/board/calendar.html

Reply via email to