> We would appreciate STOMP component written in Java.

Sorry, my mistake. I understood that you created Scala component for
STOMP Java library. However since Scomp is a pure Scala library I
think that Scomp component written in Scala can be safely committed to
the ASF Camel (after review process of course).

However I suggest then to rename the component to the camel-scomp (as
we may use other STOMP libraries in other components).

My two cents for the beginning:
* rename module to camel-scomp
* instead of putting patched files into org.fusesource.stomp.scomp you
should consider creating pull request for the Scomp itself
* please you use Maven instead of SBT
* you could already use Camel package structure (for example for
camel-scomp use org.apache.camel.component.scomp)
* I would move StompConsumer, StompProducer and StompEndpoint to separated files

--
Henryk Konsek
http://henryk-konsek.blogspot.com

Reply via email to