Hi I shall do the refactoring over the next few days. As far as Scomp goes: The original project has not been maintained for more than a year. It uses Scala 2.9.0. As a result a lot of changes were made. I am happy to collaborate with the original author but it might be simpler to work of the branch with all the acknowledgement for the great work in the original project. I have tried to contact Dejan to get his input in this regard.
Ian On 29 Jan 2013, at 9:45 PM, hekonsek [via Camel] <ml-node+s465427n5726521...@n5.nabble.com> wrote: > > We would appreciate STOMP component written in Java. > > Sorry, my mistake. I understood that you created Scala component for > STOMP Java library. However since Scomp is a pure Scala library I > think that Scomp component written in Scala can be safely committed to > the ASF Camel (after review process of course). > > However I suggest then to rename the component to the camel-scomp (as > we may use other STOMP libraries in other components). > > My two cents for the beginning: > * rename module to camel-scomp > * instead of putting patched files into org.fusesource.stomp.scomp you > should consider creating pull request for the Scomp itself > * please you use Maven instead of SBT > * you could already use Camel package structure (for example for > camel-scomp use org.apache.camel.component.scomp) > * I would move StompConsumer, StompProducer and StompEndpoint to separated > files > > -- > Henryk Konsek > http://henryk-konsek.blogspot.com > > > If you reply to this email, your message will be added to the discussion > below: > http://camel.465427.n5.nabble.com/Contributing-Apollo-Component-tp5726153p5726521.html > To unsubscribe from Contributing Apollo Component, click here. > NAML -- View this message in context: http://camel.465427.n5.nabble.com/Contributing-Apollo-Component-tp5726153p5726564.html Sent from the Camel Development mailing list archive at Nabble.com.
