Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/240#discussion_r84229327
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/newflow/complexobjects/StructObject.java
 ---
    @@ -0,0 +1,19 @@
    +package org.apache.carbondata.processing.newflow.complexobjects;
    +
    +public class StructObject {
    +
    +  private Object[] data;
    +
    +  public StructObject(Object[] data) {
    +    this.data = data;
    +  }
    +
    +  public Object[] getData() {
    +    return data;
    +  }
    +
    +  public void setData(Object[] data) {
    --- End diff --
    
    instead of just setting data, I think it is better to add function like 
`addMember(Object member)`, so that in `StructParserImpl` can make use of 
`addMember`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to