Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/240#discussion_r84226906
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java
---
@@ -114,11 +114,15 @@ protected CarbonRowBatch
processRowBatch(CarbonRowBatch rowBatch) {
/**
* It is called when task is called successfully.
*/
- public abstract void finish();
+ public void finish() {
+ // implementation classes can override to update the status.
+ }
/**
* Closing of resources after step execution can be done here.
*/
- public abstract void close();
+ public void close() {
+ // implementation classes can override to close the resources if any
available.
--- End diff --
The comment is not so clear, is this called in case of failure?
in `finish()`, resources also need to be released, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
