Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/240#discussion_r84229694
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/newflow/constants/DataLoadProcessorConstants.java
 ---
    @@ -33,4 +33,8 @@
       public static final String COMPLEX_DELIMITERS = "COMPLEX_DELIMITERS";
     
       public static final String DIMENSION_LENGTHS = "DIMENSION_LENGTHS";
    +
    --- End diff --
    
    can you rename this class to a more meaningful name like `DataLoadOptions`. 
It will be exposed to user as data load options, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to