Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85038702
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
---
@@ -117,9 +113,11 @@ private TimeStampDirectDictionaryGenerator() {
* @return dictionary value
*/
@Override public int generateDirectSurrogateKey(String memberStr) {
- SimpleDateFormat timeParser = new
SimpleDateFormat(CarbonProperties.getInstance()
- .getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
- CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT));
+ SimpleDateFormat timeParser = threadLocal.get();
+ if(timeParser == null){
+ timeParser = new SimpleDateFormat(dateFormat);
+ threadLocal.set(timeParser);
+ }
timeParser.setLenient(false);
--- End diff --
Please extract above codes to a new initial method, and invoke this method
in different thread.
It it not good to run these codes in generateDirectSurrogateKey method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
