Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85036554
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
---
@@ -39,37 +39,32 @@
*/
public class TimeStampDirectDictionaryGenerator implements
DirectDictionaryGenerator {
- private TimeStampDirectDictionaryGenerator() {
+ private ThreadLocal<SimpleDateFormat> threadLocal = new ThreadLocal<>();
- }
-
- public static TimeStampDirectDictionaryGenerator instance =
- new TimeStampDirectDictionaryGenerator();
+ private String dateFormat;
/**
* The value of 1 unit of the SECOND, MINUTE, HOUR, or DAY in millis.
*/
- public static final long granularityFactor;
+ public long granularityFactor;
/**
* The date timestamp to be considered as start date for calculating the
timestamp
* java counts the number of milliseconds from start of "January 1,
1970", this property is
* customized the start of position. for example "January 1, 2000"
*/
- public static final long cutOffTimeStamp;
+ public long cutOffTimeStamp;
/**
* Logger instance
*/
+
private static final LogService LOGGER =
-
LogServiceFactory.getLogService(TimeStampDirectDictionaryGenerator.class.getName());
+
LogServiceFactory.getLogService(TimeStampDirectDictionaryGenerator.class.getName());
--- End diff --
please correct all code style
wrap line indentation length is 4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
