Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85035902
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/DirectDictionaryKeyGeneratorFactory.java
---
@@ -39,14 +40,26 @@ private DirectDictionaryKeyGeneratorFactory() {
* @param dataType DataType
* @return the generator instance
*/
- public static DirectDictionaryGenerator
getDirectDictionaryGenerator(DataType dataType) {
+ public static DirectDictionaryGenerator
getDirectDictionaryGenerator(DataType dataType,
+
String dateFormat) {
DirectDictionaryGenerator directDictionaryGenerator = null;
switch (dataType) {
case TIMESTAMP:
- directDictionaryGenerator =
TimeStampDirectDictionaryGenerator.instance;
+ directDictionaryGenerator = new
TimeStampDirectDictionaryGenerator(dateFormat);
break;
default:
+ }
+ return directDictionaryGenerator;
+ }
+ public static DirectDictionaryGenerator
getDirectDictionaryGenerator(DataType dataType) {
+ DirectDictionaryGenerator directDictionaryGenerator = null;
+ switch (dataType) {
+ case TIMESTAMP:
+ directDictionaryGenerator = new TimeStampDirectDictionaryGenerator(
+ CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT);
--- End diff --
here need to use CarbonProperty
CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
