Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/263#discussion_r87120631
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -1112,24 +1085,27 @@ case class LoadTableUsingKettle(
val dataLoadSchema = new CarbonDataLoadSchema(table)
// Need to fill dimension relation
carbonLoadModel.setCarbonDataLoadSchema(dataLoadSchema)
- var storeLocation = ""
val configuredStore =
CarbonLoaderUtil.getConfiguredLocalDirs(SparkEnv.get.conf)
- if (null != configuredStore && configuredStore.nonEmpty) {
- storeLocation =
configuredStore(Random.nextInt(configuredStore.length))
- }
- if (storeLocation == null) {
- storeLocation = System.getProperty("java.io.tmpdir")
- }
var partitionLocation = relation.tableMeta.storePath + "/partition/"
+
relation.tableMeta.carbonTableIdentifier.getDatabaseName + "/" +
relation.tableMeta.carbonTableIdentifier.getTableName + "/"
- storeLocation = storeLocation + "/carbonstore/" + System.nanoTime()
val columinar = sqlContext.getConf("carbon.is.columnar.storage",
"true").toBoolean
val kettleHomePath = CarbonScalaUtil.getKettleHome(sqlContext)
+ val useKettle = options.get("use_kettle") match {
+ case Some(value) => value.toBoolean
+ case _ =>
+ val useKettleLocal = System.getProperty("use.kettle")
+ if (useKettleLocal == null) {
+ sqlContext.sparkContext.getConf.get("use_kettle_default",
"true").toBoolean
--- End diff --
Seems not very good to embedded this option string in this class, can we
move it to `CarbonOption`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
