Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/263#discussion_r87124860
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
---
@@ -952,10 +951,9 @@ private String getCarbonLocalBaseStoreLocation() {
// In that case it will have first value empty and other values will
be null
// So If records is coming like this then we need to write this
records as a bad Record.
- if (null == r[0] && badRecordConvertNullDisable) {
+ if (null == r[0] && badRecordslogger.isBadRecordConvertNullDisable()) {
badRecordslogger
- .addBadRecordsToBuilder(r, "Column Names are coming NULL",
"null",
- badRecordsLogRedirect, badRecordsLoggerEnable);
+ .addBadRecordsToBuilder(r, "Column Names are coming NULL",
"null");
--- End diff --
all caller of `addBadRecordsToBuilder`, the laster parameter always passing
`"null"`, it can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
