Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/263#discussion_r87124691
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/BadRecordslogger.java
---
@@ -81,13 +81,24 @@
*/
private String taskKey;
+ private boolean badRecordsLogRedirect;
+
+ private boolean badRecordLoggerEnable;
+
+ private boolean badRecordConvertNullDisable;
+
// private final Object syncObject =new Object();
- public BadRecordslogger(String key, String fileName, String storePath) {
+ public BadRecordslogger(String key, String fileName, String storePath,
--- End diff --
This class name is not correct, please rename to `BadRecordsLogger`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
