You may want to wait until CASSANDRA-14607 is finished before starting on 14712. I think it will end up unwinding most of the stuff requiring building with dual jdks (either as part of that ticket or an immediate follow on).
I'm still working on making sure I haven't broken anything, but I'm currently able to build with a single jdk (8 or 11) without any problems. I also haven't run into any problems running a strictly jdk 8 build in java 11. I have more testing to do, but it seems ok so far. > On Mar 13, 2019, at 4:14 PM, Stefan Miklosovic > <stefan.mikloso...@instaclustr.com> wrote: > > Hi, > > how do I assign myself to > https://issues.apache.org/jira/browse/CASSANDRA-14712 ? > > I read the doco here (1) but I think that workflow does not apply to > cassandra-builds repo. > > Should I do this first and then notify people? Until then it might happen > that my time would be wasted as somebody else would start to work on that > simultaneously. > > (1) https://cassandra.apache.org/doc/latest/development/patches.html#patches > > On Thu, 14 Mar 2019 at 08:46, Jordan West <jorda...@gmail.com> wrote: > >> A couple related JIRAs for reference: >> >> https://issues.apache.org/jira/browse/CASSANDRA-14714 >> https://issues.apache.org/jira/browse/CASSANDRA-14712 >> >> On Wed, Mar 6, 2019 at 7:34 PM Michael Shuler <mich...@pbandjelly.org> >> wrote: >> >>> On 3/6/19 7:10 PM, Stefan Miklosovic wrote: >>>> I am trying to build 4.0 from sources and prior to this I was doing >>>> >>>> ant artifacts >>>> >>>> in order to get distribution tarball to play with. >>>> >>>> If I understand this right, if I do not run Ant with Java 11, >>>> java.version.8 will be true so it will skip building tarballs. >>> >>> Correct. You'll get a JDK8-only jar, but no full tar artifact set. >>> >>>> 1) Why would one couldnt create a tarball while running on Java 8 only? >>> >>> The build system needs a dual-JDK install to build the artifacts with >>> support for each/both. >>> >>>> 2) What is the current status of Java 11 / Java 8? Is it there just "to >>> try >>>> it out if it runs with that" or are there different reasons behind it? >>> >>> JDK8 runtime is the default, JDK11 runtime is optional, but supported. >>> Here's the JIRA with all the details: >>> https://issues.apache.org/jira/browse/CASSANDRA-9608 >>> >>> I just pushed a WIP branch to do a dual-JDK build via docker, since we >>> need to work on this, too. (lines may wrap:) >>> >>> git clone -b tar-artifact-build >>> https://gitbox.apache.org/repos/asf/cassandra-builds.git >>> >>> cd cassandra-builds/ >>> >>> docker build -t cass-build-tars -f docker/buster-image.docker docker/ >>> >>> docker run --rm -v `pwd`/dist:/dist `docker images -f >>> label=org.cassandra.buildenv=buster -q` /home/build/build-tars.sh trunk >>> >>> After all that, here's my tar artifacts: >>> >>> (tar-artifact-build)mshuler@hana:~/git/cassandra-builds$ ls -l dist/ >>> total 94328 >>> -rw-r--r-- 1 mshuler mshuler 50385890 Mar 6 21:16 >>> apache-cassandra-4.0-SNAPSHOT-bin.tar.gz >>> -rw-r--r-- 1 mshuler mshuler 46198947 Mar 6 21:16 >>> apache-cassandra-4.0-SNAPSHOT-src.tar.gz >>> >>> Or you could drop a dual-JDK install on your machine, export the env >>> vars you found and `ant artifacts` should produce the tars :) >>> >>> -- >>> Kind regards, >>> Michael >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org >>> For additional commands, e-mail: dev-h...@cassandra.apache.org >>> >>> >> > > Stefan Miklosovic --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands, e-mail: dev-h...@cassandra.apache.org
