I left my comments on the JIRA itself but generally they mirror Scott and Joeys thoughts.
Jordan On Wed, Jul 26, 2023 at 07:26 C. Scott Andreas <sc...@paradoxica.net> wrote: > Peter, thanks for your message. > > You are receiving these emails because your address is subscribed to the > Apache Cassandra "dev@" developer mailing list. You can unsubscribe from > this list by sending an email to dev-unsubscr...@cassandra.apache.org. > Subscribers to the mailing list are not able to take this action on others' > behalf. > > More information on the project's mailing lists and how to join/leave them > is here: https://cassandra.apache.org/_/community.html > > Cheers, > > – Scott > > On Jul 26, 2023, at 7:11 AM, C. Scott Andreas <sc...@paradoxica.net> > wrote: > > > Can you say more about the shape of your concern? > > JCA/JCE conformance and correctness of the functions implemented are a > responsibility of the ACCP/Corretto test suite (link > <https://github.com/corretto/amazon-corretto-crypto-provider/tree/main/tst/com/amazon/corretto/crypto/provider/test>). > These are thoroughly exercised by Amazon and bundled into the Corretto JDK > distribution Amazon ships as well. > > With regard to Cassandra, the hash and cryptographic functions utilized in > ACCP are also thoroughly exercised by Cassandra’s unit and in-JVM dtest > suite. > > I wouldn’t propose fragmenting our build into a matrix of JDK x arch x > ACCP/no, in the same way that we wouldn’t for tcnative vs. not. > > - Scott > > On Jul 26, 2023, at 6:48 AM, Mick Semb Wever <m...@apache.org> wrote: > > > >> So if a service is not there it will just search where it is next. I >> completely forgot this aspect of it ... Folks from Corretto forgot to >> mention this behavior as well, interesting. It is not as we are going to >> use this _as the only provider_. >> > > > I'm still uncomfortable assuming upgrades work without having the > appropriate tests in place. That's the crux for me. Existing JCE tests > (with and without accp) should cover this? > > >
