PengZheng commented on code in PR #472:
URL: https://github.com/apache/celix/pull/472#discussion_r1073130698
##########
bundles/remote_services/discovery_shm/CMakeLists.txt:
##########
@@ -37,7 +37,9 @@ target_include_directories(rsa_discovery_shm PRIVATE
$<TARGET_PROPERTY:Celix::rsa_discovery_common,INCLUDE_DIRECTORIES>
$<TARGET_PROPERTY:Celix::civetweb,INCLUDE_DIRECTORIES>
)
-target_link_libraries(rsa_discovery_shm PRIVATE Celix::framework CURL::libcurl
${LIBXML2_LIBRARIES})
+target_link_libraries(rsa_discovery_shm PRIVATE
+ Celix::framework CURL::libcurl ${LIBXML2_LIBRARIES}
Celix::log_helper
Review Comment:
For libxml2, there is no problem using `LIBXML2_LIBRARIES`, since it is the
same variable used in conan generated `conan-official-libxml2-variables.cmake`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
