PengZheng commented on code in PR #472:
URL: https://github.com/apache/celix/pull/472#discussion_r1073394354


##########
conanfile.py:
##########
@@ -229,6 +231,14 @@ def requirements(self):
             self.requires("czmq/4.2.0")
             self.options['czmq'].shared = True
 
+            #If czmq is needed, disable crypto for libzip to prevent openssl 
conflict:
+            # 'czmq/4.2.0' requires 'openssl/1.1.1m' while 'libcurl/7.86.0' 
requires 'openssl/1.1.1s'
+            self.options['libzip'].crypto = False

Review Comment:
   The point is that we should specify minimal requirements to the upstream, 
and leave the ultimate power of opting-out/overriding to our downstream.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to