PengZheng commented on code in PR #472:
URL: https://github.com/apache/celix/pull/472#discussion_r1080970614
##########
.github/workflows/ubuntu.yml:
##########
@@ -1,37 +1,82 @@
name: Celix Ubuntu
-on: [push, pull_request]
+on:
+ push:
+ pull_request:
+ schedule:
+ - cron: '0 0 * * *'
jobs:
- build:
- runs-on: ${{ matrix.os }}
+
+ build-conan:
+ runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
- #os: [ubuntu-20.04]
- #compiler: [gcc, clang]
- include:
- - os: ubuntu-20.04
- name: clang
- sanitizer: false #note sanitizer on clang with cpputest does not
work
- compiler: clang
- cxx_compiler: clang++
- - os: ubuntu-20.04
- name: gcc
- sanitizer: true
- compiler: gcc
- cxx_compiler: g++
+ compiler: [ [gcc,g++], [clang,clang++] ]
+ type: [ Debug ]
Review Comment:
~~These should be put into different profiles like gcc_release, gcc_debug,
clang_release, clang_debug, and we have a matrix for these profiles. That's why
compiler mismatch happens.~~
Don't have to be done that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
