PengZheng commented on code in PR #472:
URL: https://github.com/apache/celix/pull/472#discussion_r1080971322


##########
.github/workflows/ubuntu.yml:
##########
@@ -1,37 +1,82 @@
 name: Celix Ubuntu
 
-on: [push, pull_request]
+on:
+  push:
+  pull_request:
+  schedule:
+    - cron:  '0 0 * * *'
 
 jobs:
-  build:
-    runs-on: ${{ matrix.os }}
+
+  build-conan:
+    runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        #os: [ubuntu-20.04]
-        #compiler: [gcc, clang]
-        include:
-          - os: ubuntu-20.04
-            name: clang
-            sanitizer: false #note sanitizer on clang with cpputest does not 
work
-            compiler: clang
-            cxx_compiler: clang++
-          - os: ubuntu-20.04
-            name: gcc
-            sanitizer: true
-            compiler: gcc
-            cxx_compiler: g++
+        compiler: [ [gcc,g++], [clang,clang++] ]
+        type: [ Debug ]
+    timeout-minutes: 120
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v3.3.0
+      - name: Install conan
+        run: |
+          sudo pip install -U conan
+      - name: Setup Conan Profile
+        env:
+          CC: ${{ matrix.compiler[0] }}
+          CXX: ${{ matrix.compiler[1] }}
+        run: |
+          conan profile new default --detect
+          conan profile update settings.build_type=${{ matrix.type }} default
+          #Note no backwards compatiblity for gcc5 needed, setting libcxx to 
c++11.
+          conan profile update settings.compiler.libcxx=libstdc++11 default
+          conan profile show default
+      - name: Configure and install dependencies
+        env:
+          CC: ${{ matrix.compiler[0] }}
+          CXX: ${{ matrix.compiler[1] }}

Review Comment:
   ~~ With profiles correctly setup, all of these are redundant and should be 
removed. ~~
   
   Env can be set in profiles so that we don't have to repeat.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to