PengZheng commented on code in PR #524:
URL: https://github.com/apache/celix/pull/524#discussion_r1175158534
##########
libs/framework/src/bundle_archive_private.h:
##########
@@ -41,9 +41,9 @@ extern "C" {
/**
* @brief Create bundle archive.
- *
+ * @note Symbol exported for testing purposes.
*/
-celix_status_t bundleArchive_create(celix_framework_t* fw, const char
*archiveRoot, long id, const char *location, bundle_archive_pt *bundle_archive);
+CELIX_FRAMEWORK_EXPORT celix_status_t
celix_bundleArchive_create(celix_framework_t* fw, const char *archiveRoot, long
id, const char *location, bundle_archive_pt *bundle_archive);
Review Comment:
We could use the object library for unit test. Thus it should be unnecessary.
##########
libs/framework/src/bundle_private.h:
##########
@@ -53,11 +54,14 @@ celix_status_t
celix_bundle_createFromArchive(celix_framework_t *framework, bundle_archive_pt
archive, celix_bundle_t **bundleOut);
/**
- * Get the bundle archive.
+ * @brief Get the bundle archive.
+ *
+ * @note Symbol export is needed for unit tests.
+ *
* @param[in] bundle The bundle.
* @return The bundle archive.
*/
-bundle_archive_t *celix_bundle_getArchive(const celix_bundle_t *bundle);
+CELIX_FRAMEWORK_EXPORT bundle_archive_t *celix_bundle_getArchive(const
celix_bundle_t *bundle);
Review Comment:
Let's use object target for unit test and remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
