PengZheng commented on code in PR #524: URL: https://github.com/apache/celix/pull/524#discussion_r1175183661
########## libs/utils/src/hash_map_private.h: ########## @@ -27,16 +27,17 @@ #ifndef HASH_MAP_PRIVATE_H_ #define HASH_MAP_PRIVATE_H_ -#include "exports.h" +#include "celix_utils_export.h" #include "hash_map.h" -UTILS_EXPORT unsigned int hashMap_hashCode(const void* toHash); -UTILS_EXPORT int hashMap_equals(const void* toCompare, const void* compare); +//note functions used for testing, so export is needed +CELIX_UTILS_EXPORT unsigned int hashMap_hashCode(const void* toHash); Review Comment: Use object library instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
