PengZheng commented on code in PR #524:
URL: https://github.com/apache/celix/pull/524#discussion_r1175163929
##########
libs/framework/src/bundle_revision_private.h:
##########
@@ -60,7 +62,7 @@ struct bundleRevision {
* - CELIX_SUCCESS when no errors are encountered.
* - CELIX_ENOMEM If allocating memory for
<code>bundle_revision</code> failed.
*/
-celix_status_t bundleRevision_create(celix_framework_t* fw, const char *root,
const char *location, manifest_pt manifest, bundle_revision_pt
*bundle_revision);
+CELIX_FRAMEWORK_EXPORT celix_status_t
celix_bundleRevision_create(celix_framework_t* fw, const char *root, const char
*location, manifest_pt manifest, bundle_revision_pt *bundle_revision);
Review Comment:
Use object target for unit test instead of export private symbol.
##########
libs/framework/src/celix_framework_utils_private.h:
##########
@@ -20,17 +20,20 @@
#ifndef CELIX_FRAMEWORK_UTILS_PRIVATE_H_
#define CELIX_FRAMEWORK_UTILS_PRIVATE_H_
+#include <time.h>
#include "celix_framework_utils.h"
-
-#include <time.h>
+#include "celix_framework_export.h"
#ifdef __cplusplus
extern "C" {
#endif
/**
* @brief Checks whether the provided bundle url is newer than the provided
time.
+ *
+ * @note Symbol export is required for unit testing.
Review Comment:
Using object target for unit test should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
