PengZheng commented on code in PR #627: URL: https://github.com/apache/celix/pull/627#discussion_r1327933445
########## misc/experimental/rust/celix/Cargo.toml: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +name = "celix" +version = "0.0.1" + +[dependencies] +celix_bindings = { path = "../celix_bindings" } + +[lib] +name = "celix" +path = "src/lib.rs" +crate-type = ["rlib"] Review Comment: Now it's OK to have static libcelix. Considering its size, 200KB for x64 release build, it might be preferable to built as shared object. But unfortunately I've not found any way to make BUILD_RPATH work for Corrosion, without which it is quite inconvenient to run the resulting binary in the build tree. Even if we can add `BUILD_RPATH` via build.rs, I don't know how to make RPATH rewrite work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
