PengZheng commented on code in PR #627:
URL: https://github.com/apache/celix/pull/627#discussion_r1328054070


##########
misc/experimental/rust/celix_bindings/src/celix_bindings.h:
##########
@@ -30,3 +30,6 @@
 #include "celix_framework.h"
 #include "celix_framework_factory.h"
 #include "celix_framework_utils.h"
+
+#include "celix_shell_command.h"
+#include "celix_log_service.h"

Review Comment:
   Now all components (including `framework` and `utils`) are optional, these 
headers may be missing.
   
   For Conan, intra-package and inter-package dependency deduction work like 
charm. But we need to think about how to make Cargo and Conan work together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to