PengZheng commented on code in PR #627:
URL: https://github.com/apache/celix/pull/627#discussion_r1328049324
##########
misc/experimental/rust/celix_bindings/build.rs:
##########
@@ -44,19 +58,15 @@ fn main() {
println!("cargo:info=Start build.rs for celix_bindings");
let include_paths = print_include_paths().unwrap();
- let mut builder = bindgen::Builder::default()
- .header("src/celix_bindings.h");
+ let mut builder =
bindgen::Builder::default().header("src/celix_bindings.h");
// Add framework and utils include paths
for path in &include_paths {
builder = builder.clang_arg(format!("-I{}", path));
Review Comment:
As mentioned earlier, `-I` is not enough, we may need `-D` and other compile
options (like `-pthread`).
It is hard to tell whether it matters for now without checking each target's
`INCLUDE_DIRECTORIES`, `COMPILE_DEFINITIONS` and `COMPILE_OPTIONS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
