Github user MJJoyce commented on the pull request:
https://github.com/apache/climate/pull/154#issuecomment-78321977
+1 Chris. The only reason I was bringing this up is that this is seems to
be a fix to code that @MBoustani already committed to the code base. I'm fine
with this being the only CLI example in the code base but the only thing making
this something that is part of "RCMES" instead of a generic OCW CLI is ~1 line
(see above). This was the same logic that was applied the UI. There were
actually far more changes to the UI in order to make that generic for OCW
instead of being branded.
If we are going to commit this as the RCMES CLI that is an example tool
built on top of OCW then I think it's beneficial to discuss some small changes
to the repository structure. I don't think top level folders should be for
outside example use-cases that aren't supported by the project and it needs to
be clear (in a README or otherwise) that questions on how to use it go to the
appropriate mailing lists. At one point someone brought up the idea of an
Examples-esque folder for stuff like this to be put in (maybe it was
@kwhitehall?) and I think that's a good idea.
All that being said, my +1 goes to stripping out the small amount of config
that brands this RCMES and making this the new OCW CLI.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
