Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-139986534
Hi @mike-tutkowski
I've skimmed through the code in this PR and I saw quite a lot of nice
modifications. Things like proper formatting, stricter object encapsulation,
breaking code down in small methods, just to name a few.
However, I found it quite strange that in a PR where you've changed 58
files (adding 1,410 and removing 214 lines), you did not touch a single test
class. (Although you touched 1 class that is used for integration testing -
DirectAgentManagerSimpleImpl.)
That seems to fall short from any reasonable amount of automated test
coverage for your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
