Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r39390513
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1589,8 +1589,8 @@ protected StringBuilder createGuestBootLoadArgs(final
NicProfile guestNic, final
protected StringBuilder createRedundantRouterArgs(final NicProfile
nic, final DomainRouterVO router) {
final StringBuilder buf = new StringBuilder();
- final long networkId = nic.getNetworkId();
- final NetworkVO network = _networkDao.findById(networkId);
+ // final long networkId = nic.getNetworkId();
--- End diff --
While making changes in this file, I noticed that Eclipse was pointing out
that the variable network was not in use. Instead of removing the entire line,
I just commented it out in case someone later wanted to easily resume making
use of this variable.
Once I commented it out, Eclipse pointed out that the variable networkId
was no longer in use. Same story for it with regards to commenting it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
