Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1056#issuecomment-155545730
Got it. Shouldnât we create a PR changing the Java compilation level to
1.8?
@DaanHoogland, I still have a doubt about the need of that
âselectHypervisorHostâ method call. If you take a look at the stack of
calls, the method that starts the process is
âcom.cloud.hypervisor.HypervisorGuruManagerImpl.getGuruProcessedCommandTargetHost(long,
Command)â that method makes me think that we could just use the host that it
receives as a parameter instead of looking for another one.
What is the point on getting a host at random? There was not even a check
if the hypervisor type of the host that was selected is the same as the host
that initiated the whole process.
Moreover, line 79 of âgetGuruProcessedCommandTargetHostâ, already uses
the hypervisor type of the host that is being sent as a parameter; I am seeing
why that call âendPointSelector.selectHypervisorHostâ is needed. It seems
that we could just remove lines 114 and 115 (prior to the modifications that
@DaanHoogland did) and we would be good to go, without much complications
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
