Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1206#issuecomment-164415638
  
    I don't agree, for two reasons
    1. making the field required constitutes a backwards incompatibility of the 
API
    2. we should use as much reasonable defaults as posible as to not burdon 
the user with decision they don't strictly have to make.
    
    I do agree with the present implementation as can be seen in the diff at 
this moment:
    ```
    -        if (userSpecifiedName == null) {
    +        if (userSpecifiedName == null || userSpecifiedName.isEmpty()) {
    ```
    Though the screenshots are not real tests I can live with them for this 
change: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to