Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1206#issuecomment-164417605
Hi @nitin-maharana I agree with @DaanHoogland, we should maintain backward
compatibility. I almost liked you code, I would just suggest you extracting it
to a method such as getVolumeName or getCreateVolumeNameIfNeeded (sorry for the
lack of creativity, today I am out of inspiration).
After you extracted the code to a method, you should be able to write at
least two test cases to make sure it is working as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
