Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50333804
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -48,6 +49,9 @@
@ResourceWrapper(handles = MigrateCommand.class)
public final class LibvirtMigrateCommandWrapper extends
CommandWrapper<MigrateCommand, Answer, LibvirtComputingResource> {
+ private static final String CONTENTS_WILDCARD = ".*";
+ private static final String GRAPHICS_ELEM_END = "/graphics>";
--- End diff --
why would that be needed, the match is conclusive enough without it. Adding
it would be purely cosmetic, wouldn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
