Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58763970
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGuestOsIdentifier
translateGuestOsIdentifier(String cpuArc
return VirtualMachineGuestOsIdentifier.OTHER_GUEST;
}
+ private String translateGuestOsIdentifierEx(String cpuArchitecture,
String guestOs, String cloudGuestOs) {
--- End diff --
Curious, why 2 or 3; not 10 or 100?
This method can be removed if PR
https://github.com/apache/cloudstack/pull/1397 is accepted, which bumps vmware
dependency version to sdk 6.0 which has the additional guest os identifier
(i.e. no need to this extra translation).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
