[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58767464
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
    @@ -4729,6 +4729,17 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
             return VirtualMachineGuestOsIdentifier.OTHER_GUEST;
         }
     
    +    private String translateGuestOsIdentifierEx(String cpuArchitecture, 
String guestOs, String cloudGuestOs) {
    +        if (cloudGuestOs != null) {
    --- End diff --
    
    @bhaisaab, I did not understand what you said.
    
    The way it is coded right now when “cloudGuestOs == null ”, it will be 
executed the line 4740. Do you agree with that?
    
    My suggestion is not purely cosmetics; it is to reduce code complexity. You 
can maintain that behavior while removing cyclomatic complexity and that I 
think it is worth.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---