Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58768337
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1924,6 +1935,23 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
throw new
InvalidParameterValueException("Cannot migrate ROOT volume of a stopped VM to a
storage pool in a different VMware datacenter");
}
}
+
--- End diff --
I disagree with you here. Those huge (really huge) methods that ACS has are
the rock in our shoes when writing unit and integration tests (not talking
about functional tests here). It is almost impossible to write and maintain a
test case for a method with 50, 100, 500+ lines.
Even though a method is not used in more than one place, I believe it is a
good practice to break them into smaller ones whenever possible. That
facilitates the writing of unit and integration tests cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
