Github user swill commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1363#discussion_r58813816
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java ---
    @@ -77,7 +80,18 @@ public Long getServiceOfferingId() {
         }
     
         public Map<String, String> getDetails() {
    -        return details;
    +        Map<String, String> customparameterMap = new HashMap<String, 
String>();
    +        if (details != null && details.size() != 0) {
    +            Collection parameterCollection = details.values();
    +            Iterator iter = parameterCollection.iterator();
    +            while (iter.hasNext()) {
    +                HashMap<String, String> value = (HashMap<String, 
String>)iter.next();
    --- End diff --
    
    Thanks @DaanHoogland.  @ustcweizhou can you look into improving this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to