Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-210081688
@rafaelweingartner The issue is not one of style but performance and
availability. The garbage collector skips reachability evaluations of ``final
static`` fields where it must perform those for instance variables. This cost
adds up when a large number of object is allocated and deallocated. Second,
you cannot log from a static method. Our standard in the codebase is to have
``final static`` loggers, and I don't see a compelling reason to step away from
it.
In terms of the Mockito approach, I wouldn't have an opinion if the unit
test where not requiring us to change the class. The test should always be the
servant of the system not the other way around. Personally, I find mocks to be
an obfuscation especially when the thing being mocked provides a standard
mechanism to observe side-effects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
