Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-210086309
I see your point in regards to the garbage collector; but, that class is a
singleton, it is not going to be allocated and deallocated.
About the point about of using the log in static method; well, that class
is a singleton and I believe that they should not have static method, we are
using a dependency injection framework, we should wire things up using the
lifecycle of the framework we choose and not try to work things out with static
methods.
Actually I see that the need for unit tests reflects on the code. Code with
50, 100 and even more lines cannot be properly tested. The TDD approach affects
a lot on the design and writing of code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
