Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209435788
@syed I have seen the code, and I believe we could work a little bit here.
Are you willing to?
For instance, class "NfsSecondaryStorageResource" lines 757-768 could be
extracted to a method. Then, we can also write a test case to that method to
check if the content that is written as expected. The code at lines 757-768 is
the same as the one at lines 952-963.
After you extract that I have some other points for improvements, but
letâs walk a step at time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
