Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62782035
  
    --- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
    @@ -309,6 +314,19 @@ public void doInTransactionWithoutResult(final 
TransactionStatus status) {
                         }
                         
createVpcOffering(VpcOffering.redundantVPCOfferingName, 
VpcOffering.redundantVPCOfferingName, svcProviderMap, true, State.Enabled, 
null, false, false, true);
                     }
    +
    +                if 
(_vpcOffDao.findByUniqueName(VpcOffering.routedVPCOfferingName) == null) {
    +                    s_logger.debug("Creating default routed VPC offering " 
+ VpcOffering.routedVPCOfferingName);
    +
    +                    final Map<Service, Set<Provider>> svcProviderMap = new 
HashMap<Service, Set<Provider>>();
    +                    final Set<Provider> defaultProviders = new 
HashSet<Provider>();
    +                    defaultProviders.add(Provider.VPCVirtualRouter);
    --- End diff --
    
    Consider replacing lines 321-323 with Guava's ``SetMultiMap``


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to