Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782162
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -529,14 +545,14 @@ private boolean findCapabilityForService(final Map
serviceCapabilitystList, fina
if (serviceCapabilitystList != null &&
!serviceCapabilitystList.isEmpty()) {
final Iterator iter =
serviceCapabilitystList.values().iterator();
while (iter.hasNext()) {
- final HashMap<String, String> currentCapabilityMap =
(HashMap<String, String>) iter.next();
+ final HashMap<String, String> currentCapabilityMap =
(HashMap<String, String>)iter.next();
--- End diff --
Please type to the ``Map`` interface rather than ``HashMap`` to reduce
coupling.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
