rhtyd commented on a change in pull request #231: storage: fix volume actions URL: https://github.com/apache/cloudstack-primate/pull/231#discussion_r399178953
########## File path: src/config/section/storage.js ########## @@ -163,7 +163,12 @@ export default { icon: 'delete', label: 'Delete Volume', dataView: true, - groupAction: true + groupAction: true, + show: (record, store) => { // g_allowUserExpungeRecoverVolume Review comment: @shwstppr can you explain the comment, do we need to check anything else? Shouldn't we allow users to delete a volume? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services