[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #231: storage: fix volume actions

[GitBox]

shwstppr commented on a change in pull request #231: storage: fix volume actions
URL: https://github.com/apache/cloudstack-primate/pull/231#discussion_r399201680
 
 

 ##########
 File path: src/config/section/storage.js
 ##########
 @@ -163,7 +163,12 @@ export default {
           icon: 'delete',
           label: 'Delete Volume',
           dataView: true,
-          groupAction: true
+          groupAction: true,
+          show: (record, store) => { // g_allowUserExpungeRecoverVolume
 
 Review comment:
   @rhtyd just checked g_allowUserExpungeRecoverVolume is value from 
capabilities, 
`json.listcapabilitiesresponse.capability.allowuserexpungerecovervolume`. How 
to access that in Primate if set globally?
   
   For users, role based check is an OR condition so it will show up for user
   ![Screenshot from 2020-03-27 
17-02-56](https://user-images.githubusercontent.com/153340/77752056-d618db00-704c-11ea-8ebc-ad6925a2136c.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services