[GitHub] [cloudstack-primate] ravening opened a new pull request #446: Allow creating Compute/Disk offering as Domain admin

[GitBox]

ravening opened a new pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446


   Currently only "ROOT" admin can create compute and
   disk offering. If we login as domain admin then we
   cant create a compute and disk offering as domain
   id's is not passed to the api. If we login as
   domain admin we need to set "isPublic" to false
   so that domain id list will be displayed
   
   
   Before the changes:
   
   This is the error we get for compute/disk offering creation
   
   ![Screenshot 2020-06-23 at 10 53 
45](https://user-images.githubusercontent.com/10645273/85386378-d50c2280-b543-11ea-900f-f8ed1a6bb7a2.png)
   
   
   After the changes:
   
   The UI for copute/disk offering creation shows the domain id list
   
   ![Screenshot 2020-06-23 at 10 59 
44](https://user-images.githubusercontent.com/10645273/85386499-f8cf6880-b543-11ea-93d4-f125d13311b9.png)
   
   
   Also we no longer need to use "isrecursive=true" since it wont display the 
compute/disk offering belonging to parent domain in the child domain
   
   Let say we have parent domain "test1" and its child domain "test-11" then 
all the offerings created by "test1" will not be visible to its child domain 
"test-11" if isrecursive is true
   
   ![Screenshot 2020-06-23 at 11 16 
19](https://user-images.githubusercontent.com/10645273/85386758-464bd580-b544-11ea-9f3e-18cb8eb750be.png)
   
   
   Setting isrecursive to false will display all the parent domain offerings
   
   ![Screenshot 2020-06-23 at 11 16 
44](https://user-images.githubusercontent.com/10645273/85386832-5cf22c80-b544-11ea-9b75-1191a1ae3355.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org