[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #446: Allow creating Compute/Disk offering as Domain admin

[GitBox]

shwstppr commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444151507



##########
File path: src/views/offering/AddDiskOffering.vue
##########
@@ -358,6 +358,9 @@ export default {
       }
     },
     isAdmin () {
+      if (!['Admin'].includes(this.$store.getters.userInfo.roletype)) {
+        this.isPublic = false
+      }

Review comment:
       @ravening correct way, in my opinion, would be adding following line in 
`mounted()` method of `AddComputeOffering.vue` and `AddDiskOffering.vue`,
   `
   this.isPublic = this.isAdmin()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org