[GitHub] [cloudstack-primate] ravening commented on a change in pull request #446: Allow creating Compute/Disk offering as Domain admin

[GitBox]

ravening commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444261682



##########
File path: src/config/section/offering.js
##########
@@ -27,7 +27,6 @@ export default {
       docHelp: 
'adminguide/service_offerings.html#compute-and-disk-service-offerings',
       icon: 'cloud',
       permission: ['listServiceOfferings', 'listDomains'],
-      params: { isrecursive: 'true' },

Review comment:
       @shwstppr 
   
   Lets have I have three domains like "ROOT" -> "ROOT/test1" -> 
"ROOT/test1/test11"
   
   With `isrecursive=true` i dont see all the disk offering of domain 
"ROOT/test1" from "ROOT/test1/test11"
   
   ![Screenshot 2020-06-23 at 16 14 
09](https://user-images.githubusercontent.com/10645273/85415052-267cd780-b56d-11ea-85d2-59eddda6d024.png)
   
   with `isrecursive=false` then I do see all offerings of "ROOT/test1" from 
"ROOT/test1/test11"
   
   ![Screenshot 2020-06-23 at 16 14 
27](https://user-images.githubusercontent.com/10645273/85415174-4a401d80-b56d-11ea-8f05-2d78e79c0b1a.png)
   
   
   The cloudmonkey also shows same
   
   ```
   (test11) 🐵 > list diskofferings listall=true filter=name,domain 
isrecursive=true
   {
     "count": 5,
     "diskoffering": [
       {
         "name": "Small"
       },
       {
         "name": "Medium"
       },
       {
         "name": "Large"
       },
       {
         "name": "Custom"
       },
       {
         "domain": "/test1/test-11/",
         "name": "test-11only"
       }
     ]
   }
   ```
   
   With isrecursive=false
   
   ```
   (test11) 🐵 > list diskofferings listall=true filter=name,domain
   {
     "count": 8,
     "diskoffering": [
       {
         "name": "Small"
       },
       {
         "name": "Medium"
       },
       {
         "name": "Large"
       },
       {
         "name": "Custom"
       },
       {
         "domain": "/test1/",
         "name": "test1only"
       },
       {
         "domain": "/test1/test-11/",
         "name": "test-11only"
       },
       {
         "domain": "/test1/",
         "name": "test1-and-11"
       },
       {
         "domain": "/",
         "name": "root-test1-test11"
       }
     ]
   }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org