shwstppr commented on a change in pull request #446:
URL: https://github.com/apache/cloudstack-primate/pull/446#discussion_r444270921



##########
File path: src/config/section/offering.js
##########
@@ -27,7 +27,6 @@ export default {
       docHelp: 
'adminguide/service_offerings.html#compute-and-disk-service-offerings',
       icon: 'cloud',
       permission: ['listServiceOfferings', 'listDomains'],
-      params: { isrecursive: 'true' },

Review comment:
       With current state I don't think we can show parent domain offerings in 
this view. It will allow showing editing UI for those offerings although user 
doesn't have access to edit them.
   As far as I remember, legacy UI allow showing only current and subdomain 
offerings in this view and while all accessible offering in deplovm view where 
isrecursive as true. In any of these better option would be to add an issue in 
CloudStack itself. @ravening




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to